Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed escaping for run "...", as: 'user' #5

Merged
merged 2 commits into from Oct 20, 2011

Conversation

jistr
Copy link
Contributor

@jistr jistr commented Oct 20, 2011

No description provided.

@jistr
Copy link
Contributor Author

jistr commented Oct 20, 2011

Hi Davide, thanks for this awesome tool.

I fixed command escaping that is done when using run 'command', as: 'user'

  1. There's no need to escape commands when using sudo.
  2. Single quote escaping in shells (bash/zsh/...) should be done to turn every ' into '\'' (no kidding), and that's what my second commit does. (Although at a first glance it looks like there's too many \ characters, when you run it, it will return correct results.)

Cheers!

@DAddYE
Copy link
Owner

DAddYE commented Oct 20, 2011

Thank you man!

DAddYE added a commit that referenced this pull request Oct 20, 2011
Fixed escaping for run "...", as: 'user'
@DAddYE DAddYE merged commit e32c792 into DAddYE:master Oct 20, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants