Adds D4 statement being executed to compiler exceptions. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynrhodes
requested changes
Aug 23, 2017
| @@ -348,4 +348,9 @@ | |||
| <data name="SchemaObjectDescription.ServerLink" xml:space="preserve"> | |||
| <value>Server link "{0}" ({1} on {2}{3})</value> | |||
| </data> | |||
| <data name="ExceptionInContext" xml:space="preserve"> | |||
There was a problem hiding this comment.
I cannot find anywhere in the code that this string is referenced? Is this supposed to be part of this commit?
| @@ -12,7 +12,7 @@ namespace Alphora.Dataphor.DAE.Runtime | |||
| using Alphora.Dataphor.DAE.Debug; | |||
| using Alphora.Dataphor.DAE.Runtime.Instructions; | |||
|
|
|||
| public class RuntimeException : DAEException, ILocatorException | |||
| public class RuntimeException : DAEException, ILocatorException, ICodeContextException | |||
| { | |||
There was a problem hiding this comment.
I don't see anywhere that would ever set the context of a RuntimeException? Am I missing it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an interface so that this commonality between runtime and compiler exceptions is represented.