Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Remove trailing white-spaces and fix indentation in CMakeLists.txt #62

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Dec 20, 2023

Removing trailing whitespaces streamline comparison between revisions of the code.

For additional references:


Once integrated, the commits prefixed with STYLE: should be added to a file called .git-blame-ignore-revs file.

This file lists revisions that should be ignored when considering attribution for the actual code written. Code style changes should not be considered as modifications with regards to attribution.

To see clean and meaningful blame information.

$ git blame important.py --ignore-revs-file .git-blame-ignore-revs

To configure git to automatically ignore revisions listed in a file on every call to git blame.

$ git config blame.ignoreRevsFile .git-blame-ignore-revs

Based on:

@jcfr
Copy link
Contributor Author

jcfr commented Dec 20, 2023

re: #59

@allemangD
Copy link
Contributor

I fixed some of these in #60 - see 56015b0 - but I only fixed files that I already touched in that PR.

I suggest merging #60 first, rebasing this PR, then merge. Since I only reformatted already-modified files it's probably fine not to worry about blame ignore for #60. I'll go ahead and add blame ignore for this PR once it's rebased and merged.

@allemangD
Copy link
Contributor

allemangD commented Jan 10, 2024

With #60 and #69 things have diverged enough that rather than trying to rebase these changes, I'll just merge #68 and then perform these same reformatting tasks on the new, updated, main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants