Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group pip install #79

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Group pip install #79

merged 3 commits into from
Jan 29, 2024

Conversation

GaelleLeroux
Copy link
Contributor

Hi @allemangD !

I tried to do what you suggested with the pip_install for ASO and ALI. Jeanne will do the other one.
I group them and ask the user the permission to install/update their librairies in Slicer.
Did I undestood well what you suggested ? Do you think it's ok ?

Thank you for your help :)

Copy link
Contributor

@allemangD allemangD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it is possible to avoid creating check_lib_installed ... I assume this is in place to avoid requiring pip install --upgrade.

If that's the case, seems like it should be fine until proper constraints files are supported. I'll merge now.

@allemangD allemangD merged commit 6b13ba9 into DCBIA-OrthoLab:main Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants