Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit customization of secure transport layer in DcmTLSSCU #59

Closed

Conversation

jogerh
Copy link

@jogerh jogerh commented May 6, 2022

Today, DcmTLSSCU requires certificate and key files to enable TLS.
The Windows platform has its own certificate store, and exporting all
certificates to the filesystem may not be desireable. Instead, we want
to populate the OpenSSL certificate store in memory from the Windows
certificate store.

This change allow us to derive from DcmTLSSCU to customize how TLS
transport layers are created and configured before we leave it over
to the default DcmTLSSCU::initNetwork implementation.

Today, DcmTLSSCU requires certificate and key files to enable TLS.
The Windows platform has its own certificate store, and exporting all
certificates to the filesystem may not be desireable. Instead, we want
to populate the OpenSSL certificate store in memory from the Windows
certificate store.

This change allow us to derive from DcmTLSSCU to customize how TLS
transport layers are created and configured before we leave it over
to the default DcmTLSSCU::initNetwork implementation.
@jogerh
Copy link
Author

jogerh commented May 16, 2022

Closing because a better option is to not use DcmTLSSCU. We achieve the same in a more elegant way by inheriting from DcmSCU, and provide the SSL context through DcmSCU::useSecureConnection

@jogerh jogerh closed this May 16, 2022
@jogerh jogerh deleted the DcmTLSSCU_CustomizeTransportLayer branch May 16, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant