Fix issue with port conflicts when running automated DICOM networking tests in a CI infrastructure #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 28, 2022 22:31
…assigned to it. This change updates the network settings accordingly.
Helper function scu_sends_echo would always fail in this test. Fixed by taking into account that negotiateAssociation should fail in this test.
…instead of using hard coded or randomized ports. This should allow running multiple tests concurrently. Since we need to obtain the assigned port before using it with any SCU, we need to call DcmSCP::openListenPort from the main thread. Therefore, we unfortunately can't test the DcmSCP through DcmSCP::Listen() function.
|
Integrated with commit d86bea (visible on master within the next days). Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running DICOM networking tests in a CI infrastructure, port conflicts can be a serious obstacle because only one test can run at a time. This prevents efficient utilization of CI hardware.
This change attempts to make DcmSCP more CI friendly by enabling automatic port assignment. This functionality is enabled by configuring the DcmSCP to listen to port 0. The underlying socket library will then assign an unused port to the DcmSCP when opening a listen port. The main part of this change is about propagating this automatically assigned port up to the API level.
This should prevent port conflicts when running multiple tests in parallel on the same OS instance.