New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure the rendering pipeline to do the blending the "wrong way" #6

Open

DCNick3 opened this issue Jan 13, 2023 · 1 comment

Labels

architecture inconsistency

Owner

DCNick3 commented Jan 13, 2023

So, apparently, entergram has fucked up gamma correctness in their engine...

They do not mark textures as being in sRGB space (but they are!) and therefore all computations happen without conversion to linear space (but they should be converted!)

Because of this I couldn't get the messagebox opacity to look quite right (to be the same as in the game)....

Alpha blending (RES = a * src + (1-a) * dst) was done in the different colorspace, so the result is different

To implement the same in our engine we would need to use texture views with differing srgb-ness, tracked at gfx-rs/wgpu#3237

DCNick3 added inconsistency architecture labels

Owner Author

DCNick3 commented Feb 23, 2023

Don't forget to remove extra renderpass from the movielayer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment