Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: implemented suggestions for coalition.proto #113

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Linting: implemented suggestions for coalition.proto #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
may generate different casing by convention, creating a compiler only issue.
- `net.proto` - `GetPlayerInfo.remote_address`
- `mission.proto` - `PlayerSendChatEvent.player_id`
- Corrected `proto` files with enumerations to be named correct; compiler-only breaking change, not runtime.
- `coalition.proto` - `AddGroupRequest.Point` - enum `Type` has been renamed to `PointType`
- `coalition.proto` - `AddGroupRequest` - enum members of `Skill` has been prefixed with `SKILL_`

## [0.3.0] - 2022-01-14
### Added
Expand Down
20 changes: 11 additions & 9 deletions protos/dcs/coalition/v0/coalition.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ message AddGroupRequest {
bool late_activation = 3;
string name = 4;
dcs.common.v0.Position position = 5;
repeated Point route = 6;
repeated Point waypoints = 6;
rurounijones marked this conversation as resolved.
Show resolved Hide resolved
uint32 start_time = 7;
string task = 8;
bool task_selected = 9;
Expand Down Expand Up @@ -77,24 +77,26 @@ message AddGroupRequest {
ALTITUDE_TYPE_RADIO = 2;
}

enum Type {
TYPE_UNSPECIFIED = 0;
TAKEOFF = 1;
TAKEOFF_PARKING = 2;
TURNING_POINT = 3;
TAKEOFF_PARKING_HOT = 4;
LAND = 5;
enum PointType {
// protolint:disable:next ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH
POINT_TYPE_RANDOM = 0;
POINT_TYPE_TAKEOFF = 1;
POINT_TYPE_TAKEOFF_PARKING = 2;
POINT_TYPE_TURNING_POINT = 3;
POINT_TYPE_TAKEOFF_PARKING_HOT = 4;
POINT_TYPE_LAND = 5;
}

dcs.common.v0.Position position = 1;
AltitudeType altitude_type = 2;
Type type = 3;
PointType type = 3;
string action = 4;
string form = 5;
double speed = 6;
}

enum Skill {
// protolint:disable:next ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH
SKILL_RANDOM = 0;
SKILL_AVERAGE = 1;
SKILL_GOOD = 2;
Expand Down