implement setting to limit throughput #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkusa
commented
Oct 12, 2021
rkusa
commented
Oct 12, 2021
rkusa
commented
Oct 12, 2021
rkusa
commented
Oct 12, 2021
| @@ -171,47 +171,57 @@ async fn handle_event(state: &mut State, event: Event) -> Result<(), Error> { | |||
|
|
|||
| /// Updates all units inside of the provided [State]. | |||
| async fn update_units(state: &mut State) -> Result<(), Error> { | |||
There was a problem hiding this comment.
Hiding whitespace changes makes reviewing this part easier:
rkusa
commented
Oct 12, 2021
|
Rebased due to merge conflicts 🔀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setting to limit throughput of calls that are executing inside of the mission scripting environment.
More details in inline comments. I don't really have a use-case where I'd see a difference between a throughput of
1and1000, so if you have one, it be worth testing it against this PR.Refs #26