Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slots for next, previous & close buttons #14

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

keesvanlierop
Copy link

@keesvanlierop keesvanlierop commented Mar 30, 2019

Fixes #13 by wrapping all lightbox control buttons with <slot />s.

@keesvanlierop
Copy link
Author

keesvanlierop commented Apr 5, 2019

@DCzajkowski Would you mind giving some feedback on this PR?

@DCzajkowski
Copy link
Owner

Sure! I'll look at it today or tomorrow. I've completly forgotten, sorry.

@keesvanlierop
Copy link
Author

Pretty please? :)

@DCzajkowski
Copy link
Owner

I am sorry, but I haven't had any time whatsoever this week. Don't worry, I have this on my todo list. I'll get back to you soon. I'll try today, but I can't promise anything. Sorry.

@DCzajkowski DCzajkowski merged commit 58d5958 into DCzajkowski:master Apr 30, 2019
@DCzajkowski
Copy link
Owner

DCzajkowski commented Apr 30, 2019

I am terribly sorry it took so long. I have published a new version. New slots are documented here: https://github.com/DCzajkowski/vue-pure-lightbox/tree/2.1.9#available-slots. Thank you for your contribution and have fun coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slots for previous, next and close buttons
2 participants