Insert "add chant" links to chant-proofread and chant-edit pages #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobdgm
reviewed
Aug 29, 2023
Comment on lines
242
to
243
| <br> | ||
| <a href="{% url "chant-create" source.pk %}" style="display: inline-block; margin-top:5px;"> |
There was a problem hiding this comment.
why are we using both <br> and margin-top? It might be cleaner to put these links in a <div> (each link might need its own div - not sure) and apply margin-top to each. This would eliminate the need for the br, and we may not need inline-block either...
jacobdgm
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1004. We now display a link to edit chants in a given source on the full text & volpiano edit page as well as the chant-proofread page.