Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "differentia_new" field to "differentiae_database" #1086

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

jacobdgm
Copy link
Contributor

@jacobdgm jacobdgm commented Oct 3, 2023

fixes #1084

This PR renames the differentia_new field to differentiae_database on the BaseChant model.

In a related point, I added a DeprecationWarning to our update_differentia_new management command, telling developers that they should not run this command.

I ran all our tests, and everything is passing.

@jacobdgm jacobdgm changed the title Rename "differentia_new" field to Rename "differentia_new" field to "differentiae_database" Oct 3, 2023
@jacobdgm jacobdgm marked this pull request as ready for review October 3, 2023 17:14
@jacobdgm jacobdgm merged commit 8a6d070 into DDMAL:develop Oct 3, 2023
@jacobdgm jacobdgm deleted the issue-1084 branch October 31, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseChant model: we should rename differentia_new field
2 participants