Source Detail: ensure line breaks are preserved when displaying TextFields #1087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1085
This PR fixes a bug on the Source Detail page, where the source description would all run together even if line breaks had been added while writing the description in the Source Edit page. Adding a
linebreaks
tag to the field in the template causes line breaks to be preserved.While fixing this, I looked at several of the other TextFields in our models to see if they would benefit from similar treatment.
linebreaks
tags to the Liturgical Occasions and Selected Bibliography fields in addition to the Description field, as they often contain extended descriptions.@annamorphism, perhaps you can comment on whether there are other places I should look at for applying a similar treatment, or whether there are reasons that linebreaks should not be preserved where I just added them. I'll wait for a researcher approval from you and for a technical approval from @dchiller or @lucasmarchd01 before merging this.