autocomplete: change genre, office, feast to use icontains search #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobdgm
reviewed
Nov 17, 2023
| @@ -1014,7 +1014,7 @@ def get_queryset(self): | |||
| qs = Feast.objects.all().order_by("name") | |||
| if self.q: | |||
| qs = qs.filter( | |||
| Q(name__istartswith=self.q) | Q(feast_code__istartswith=self.q) | |||
| Q(name__icontains=self.q) | Q(feast_code__istartswith=self.q) | |||
There was a problem hiding this comment.
it occurs to me now - we're not displaying the feast_code anywhere currently (within the autocomplete widget), are we? We should probably not be displaying feast_code matches if the user can't see why it's being matched...
jacobdgm
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1155
Office and Genre autocomplete widgets are now using icontains search filter on
description(nameis still istartswith since they are the shorthand letter representation). Feast are now using icontains search filter onname.