Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make separate production and staging versions of cron.txt #1299

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

jacobdgm
Copy link
Contributor

@jacobdgm jacobdgm commented Feb 6, 2024

This PR:

  • renames cron-staging.txt -> cron.txt.staging, and renames cron.txt -> cron.txt.production, thus bringing our cron configuration into alignment with our docker (in docker-compose.yml) and nginx (in conf.d/cantusdb.conf) configuration.
  • Adds cron/cron.txt to .gitignore

This PR fully resolves #1269.

Copy link
Contributor

@dchiller dchiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can reduce a deployment step...these don't need to be cat-ed anywhere before they are added to crontab, but ok as is.

@jacobdgm jacobdgm merged commit 0383346 into DDMAL:develop Feb 8, 2024
@jacobdgm jacobdgm deleted the 1269-standardize-cron branch February 8, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It would be a good idea to save separate configuration files for staging vs. production
2 participants