-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update update_cached_concordances command to comply with new spec #1333
Conversation
and update corresponding tests
django/cantusdb_project/main_app/management/commands/update_cached_concordances.py
Outdated
Show resolved
Hide resolved
django/cantusdb_project/main_app/management/commands/update_cached_concordances.py
Outdated
Show resolved
Hide resolved
django/cantusdb_project/main_app/management/commands/update_cached_concordances.py
Outdated
Show resolved
Hide resolved
django/cantusdb_project/main_app/management/commands/update_cached_concordances.py
Outdated
Show resolved
Hide resolved
…lished_vs_unpublished
I spent a few minutes looking into whether we could rename |
Were you using concat for I don't feel like this is necessary unless you want to. |
This is it, yes! Maybe I'll get around to refactoring this once we've finished rolling it out as it is. For now, though, I think we're fine as-is. |
This PR updates our
update_cached_concordances
command to output a file matching the updated specification (see #1323). In doing so, it fixes #1323.The tests have also been updated to reflect the new spec.