Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dropdown menus in header opaque #396

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Make dropdown menus in header opaque #396

merged 3 commits into from
Oct 25, 2022

Conversation

jacobdgm
Copy link
Contributor

@jacobdgm jacobdgm commented Oct 25, 2022 •
edited

This PR does several things:

  • makes the dropdown menus in the header opaque (their previous translucent state seems to have been inherited from OldCantus - I have no idea why that choice was made in the first place)
  • remove the Facebook widget and script, and add a link under "Contact" in the footer to the facebook page.
  • improve the formatting of the footer - add padding around list items, but ensure that individual lines of multi-line bullet points are not spaced super wide apart (previously, vertical "padding" had been achieved via a large line-height value)

@jwang44 jwang44 merged commit 45920ac into DDMAL:develop Oct 25, 2022
@jacobdgm jacobdgm deleted the dropdown branch October 25, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobdgm @jwang44