Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title attributes in useful places, fix Chant-by-Cantus-ID page formatting #484

Merged
merged 13 commits into from
Jan 9, 2023

Conversation

jacobdgm
Copy link
Contributor

This PR does two main things:

  • Where we display the .names of Genres and Offices (i.e. the abbreviations for these objects), it adds title="" attributes to these elements, so that the .description of the Genre/Office (i.e. the full name of the object) is displayed upon mouseover.
    • I haven't made an effort to do this in places where concordances are being displayed; the information we get from CantusIndex is not set up for these to be added without lots of extra code being written
    • Neither have I made an effort to add these to sidebars - I've only done it in the main panel for each view
  • In tables where we leave an empty column header or use an abbreviation, include title attributes to all column headers spelling out what the columns mean (e.g. in several places, we just leave empty column headers instead of writing out "Genre" or "Office", in order to save space. We also use "Mel" instead of "Volpiano Melody" and "Image" instead of "Image Link")

Along the way, I discovered that on the Chant-by-Cantus-ID page, we were displaying the string representation of chants' offices rather than their abbreviation. This caused this property to be quite out-of-proportion compared to how OldCantus renders this information. This PR fixes this.

OldCantus:
Screen Shot 2022-12-16 at 2 52 56 PM

NewCantus, previously:
Screen Shot 2022-12-16 at 2 51 29 PM

NewCantus, now:
Screen Shot 2022-12-16 at 2 52 09 PM

@jacobdgm jacobdgm merged commit 497986d into DDMAL:develop Jan 9, 2023
@jacobdgm jacobdgm deleted the office-genre-title branch January 9, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants