Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge develop into staging - 2023-06-20 edition #767

Merged
merged 27 commits into from
Jun 20, 2023
Merged

Conversation

jacobdgm
Copy link
Contributor

@jacobdgm jacobdgm commented Jun 20, 2023

Pages that have changed:

  • flatpages/default.html (used for rendering flat pages, i.e. homepage, etc.)
    • there's now a "Sources created by user" card in the right sidebar
    • in sidebars on this page, "edit chants" links no longer appear for sources that contain no chants
  • Chant edit page
    • if source contains no chants, the page now loads successfully
  • Indexer detail page
    • if user enters an invalid ID number, they'll be shown our custom 404 page rather than a blank page
  • Node redirect page
    • if user enters an invalid ID number, they'll be shown our custom 404 page rather than a blank page
  • Provenance detail page
    • unpublished sources are not shown to non-logged-in users
  • Source List page
    • table now includes a horizontal scroll bar when the window gets narrow

lucasmarchd01 and others added 27 commits June 16, 2023 18:01
Add "Sources created by user" list to homepage
View functions now raise an Http404 instead of returning an HttpResponsenotFound, resulting in a traceback when running loclaly, as expected.
Display correct 404 page for /node/ and /indexer/ redirects
…es to be displayed

...even when user is not authenticated
Fix bug in provenance_detail.html
Hide edit chants link from "my sources" sidebar on flatpages
Fix 404 error on edit-chants page for sources with no chants and deleting last chant in source
Add side scrolling to source list table
@lucasmarchd01 lucasmarchd01 merged commit d1aa9c9 into staging Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants