Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layout of Chant Search, Chant Search MS views #847

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

jacobdgm
Copy link
Contributor

@jacobdgm jacobdgm commented Jul 13, 2023

This PR improves the layout of the Chant Search and Chant Search Manuscript views. It is a first step towards setting up #843 (I had started to work on implementing a "search indexing notes" field, and the page began to look quite terrible - in an attempt to make PRs that aren't enormous, this PR is a first step towards implementing the latter feature, where we can just take everything above "Office/Mass" and duplicate/adapt it below "Melodies" for the new field.)

It fixes #846.

Previously, the "Contains"/"Starts with" box was just as large as the "Keyword search" field, which was tripping up testers:

Screenshot 2023-07-13 at 1 15 45 PM

This PR makes the "Contains" box smaller.

The fields beneath this row have also been rearranged (bootstrap deals with 12 columns, but there were 7 items equally spaced on the lower line - without this rearrangement, nothing would align visually):

Screenshot 2023-07-13 at 1 18 05 PM

Also, previously, when the window became somewhat narrow, every field would go onto its own line:
Screenshot 2023-07-13 at 1 19 04 PM

Now, when the window becomes somewhat narrow, the fields pair up, which looks a bit neater:
Screenshot 2023-07-13 at 1 20 47 PM

And now, the fields take up full lines only when the window becomes very narrow. When this happens, the "Contains" box stays smaller than the "Keyword" field:
Screenshot 2023-07-13 at 1 22 07 PM

@lucasmarchd01
Copy link
Contributor

This might be too nit-picky, but the text "keyword search" is ever so slightly higher above the widget than the other fields.

@jacobdgm
Copy link
Contributor Author

This might be too nit-picky, but the text "keyword search" is ever so slightly higher above the widget than the other fields.

Nice catch, and yes, I noticed this too - I think it also starts a tiny bit further left than the other labels. Both of these are because it's on a different row (this is to make sure it stays on its own line when the window gets really narrow). Maybe a front-end wizard can clean this up at some point, but for now, it's probably good enough.

@jacobdgm jacobdgm merged commit 3b49559 into DDMAL:develop Jul 13, 2023
@jacobdgm jacobdgm deleted the issue846 branch July 13, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting of Chant Search Page should be improved
2 participants