content overview: add tabs for models and display all objects ordered by date created #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobdgm
requested changes
Aug 1, 2023
There was a problem hiding this comment.
This looks good! I left one comment to check that Century models haven't been overlooked, and one suggesting a possible simplification to the code.
One other thing: do any tests need to be updated to match these changes? If not, maybe now is a good time to write a good set of tests for this view.
| <td class="text-wrap" style="text-align:center"> | ||
| <a href="{{ object.get_absolute_url }}"><b>{{ object.full_name }}</b></a> | ||
| {% if object.last_updated_by is None %} | ||
| {{ object.last_updated_by }} |
There was a problem hiding this comment.
Maybe it would be clearer to just put None rather than {{ object.last_updated_by }} (since we already know it's None)
Thanks for the suggestion, will do. |
jacobdgm
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, modifications are made to the content-overview page. Previously, this page would only display the last 50 updated objects in our database. The way this information was fetched was inefficient, making it impossible to scale to use all the objects in our database without affecting the page loading time. The solution implements tabs at the top of the page that represent the relevant models in our database. When the user clicks on one of these tabs, we will display all of the objects corresponding to this model ordered by "-date_created". The user can now paginate through all of these objects with 100 objects per page. Fixes #896