Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formatting of Chant Search page #911

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Improve formatting of Chant Search page #911

merged 2 commits into from
Aug 2, 2023

Conversation

jacobdgm
Copy link
Contributor

@jacobdgm jacobdgm commented Aug 1, 2023 •
edited

This PR fixes a couple of formatting-related things:

  • It removes the unnecessary space at the bottom of certain cells on the Chant Search page - previously, they'd been wrapped in <p> tags, which was adding an extra space beneath (fixes We should remove the extra line in each row of searchms results #852)
  • It changes the formatting of links: now, when you hover over them with your cursor, they become underlined rather than changing colour very slightly (as they'd previously done). This is an important accessibility fix that has been bothering me for a while.

@jacobdgm jacobdgm merged commit c44bdda into DDMAL:develop Aug 2, 2023
@jacobdgm jacobdgm deleted the formatting branch August 2, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmarchd01 lucasmarchd01 lucasmarchd01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should remove the extra line in each row of searchms results
2 participants
@jacobdgm @lucasmarchd01