Active page fix #483
Merged
Active page fix #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue where half of height was being added to find center x position, and similar with center y. Padding should be included when finding image offsets since that does impact where the image is actually displayed in diva.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how the center page is calculated (5105174) by correcting the usage of width and height and including padding. It seems padding should be included since that is part of what appears in the layout and affects where the page would be rendered.
An event 'ActivePageDidChange' is added since the active page might change while visible pages do not (e.g. pages 0 and 1 are visible but active page changes from 0 to 1 or vice versa).