Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Adds replicators! Simply tell it what you want and it'll make it so. #37

Merged
merged 7 commits into from
Mar 22, 2019

Conversation

Kmc2000
Copy link
Member

@Kmc2000 Kmc2000 commented Mar 11, 2019

https://streamable.com/g4iiw

These replicators aren't quite as horrifyingly overpowered as the real trek ones. They require 2 things:
Power
Biomatter

Why?!?!?!
Well, that means that botany isn't completely useless and it also encourages chefs to use the replicator as a supplement to their own cooking.

It starts out with barely edible food and progresses up to good foods and then pre-prepared ingredients like cake batter, dough etc. for the chef to use. You upgrade it with RnD parts.

You can examine them to see the unlocked menus and then just say what you want (don't make it a question, like can I have burger?)

Coded by AbsurdlyLudicrous, cleaned up by myself.

🆑 AbsurdlyLudicrous & Kmc2000
add: Added replicators which convert power and biomatter into edible foods.
/:cl:

Copy link
Contributor

@alexkar598 alexkar598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of review coming later:tm:

@@ -0,0 +1,322 @@
/obj/machinery/replicator //Coded by "AbsurdlyLudicrous", tweaked to use voice + cleaned up by Kmc.
name = "replicator"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalisation

@@ -0,0 +1,322 @@
/obj/machinery/replicator //Coded by "AbsurdlyLudicrous", tweaked to use voice + cleaned up by Kmc.
name = "replicator"
desc = "An advanced energy -> matter synthesizer which is charged by <i>biomatter</i> and power. Click it to see the menu and simply say what you want to it."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...nced energy -> matter sy...

Muh immersion

icon_state = "replicator"
use_power = IDLE_POWER_USE
idle_power_usage = 40
pixel_y = 32 //So it glues to the wall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if i want mine to the south,this is stuff you do in var edits in mapping or in subtypes,not the parent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REEEEE

You can do it to the south because of goonwalls

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See how APC's do their pixel stuff

use_power = IDLE_POWER_USE
idle_power_usage = 40
pixel_y = 32 //So it glues to the wall
anchored = TRUE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
anchored = TRUE
anchored = TRUE
density = TRUE

var/list/all_menus = list() //All the menu items. Built on init(). We scan for menu items that've been ordered here.
var/list/menualtnames = list("nutrients", "donk pizza", "veggie pizza", "surprise me", "you choose", "something", "i dont care","slab of meat","nutritional supplement")
var/list/temps = list("cold", "warm", "hot", "extra hot")
var/menutype = "ready" //Tracks what stage the machine's at. If it's replicating the UI pops up with "please wait!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a couple of DEFINEs or a boolean for this,death to string statuses

var/list/menutier2 = list("burger", "steak", "tea earl grey", "coffee", "fries","onion rings", "pancakes")
var/list/menutier3 = list("cheese pizza", "meat pizza", "mushroom pizza", "meat pizza", "pineapple pizza", "donkpocket pizza", "vegetable pizza")
var/list/menutier4 = list("cake batter", "dough","egg box", "flour", "milk", "enzymes", "cheese wheel", "meat slab","an insult to pizza")
var/list/all_menus = list() //All the menu items. Built on init(). We scan for menu items that've been ordered here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is, look at init()


/obj/machinery/replicator/Initialize()
. = ..()
all_menus += menutier1.Copy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this is unused

popup.open()

/obj/machinery/replicator/emag_act(mob/user)
if(emagged == FALSE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(emagged == FALSE)
if(!emagged)

all_menus += menualtnames.Copy()

/obj/machinery/replicator/ui_interact(mob/user) // The microwave Menu //I am reasonably certain that this is not a microwave
if(stat & (BROKEN|NOPOWER))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(stat & (BROKEN|NOPOWER))
if(is_operational())

/obj/machinery/replicator/power_change()
if(powered())
stat &= ~NOPOWER
START_PROCESSING(SSmachines, src)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You never stop processing,why start again?

@Kmc2000 Kmc2000 merged commit 4838fd9 into DDMers:master Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants