Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/iterable placeholder to string #224

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix/iterable placeholder to string #224

merged 2 commits into from
Aug 9, 2023

Commits on Aug 9, 2023

  1. Concatenate .toString of elements in iterableplaceholder

    @AntonOellerer
    AntonOellerer committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b45ca6d View commit details
    Browse the repository at this point in the history

  2. Fix Resolving IterablePlaceholders when no End-Marker present 

    When you have a placeholder that's being resolved to IterablePlaceholderData and
no End-Marker was present, the Word- and ExcelGenerators still tried to unroll
them. But the default behaviour should resolve a scalar value to the beans
toString method.

* Therefore, the WordGenerator#isLoopStart and ExcelGenerator#isLoopStart now
probe if a end loop marker is present and only then evaluate to true.
* The ReflectionResolver#toString method is returning the Beans toString value.
    @alexpartsch
    alexpartsch committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    7fb7cf1 View commit details
    Browse the repository at this point in the history