Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for v3. #36

Closed
DDoSolitary opened this issue Mar 26, 2018 · 13 comments
Closed

Roadmap for v3. #36

DDoSolitary opened this issue Mar 26, 2018 · 13 comments

Comments

@DDoSolitary
Copy link
Owner

DDoSolitary commented Mar 26, 2018

@Biswa96
Copy link

Biswa96 commented Mar 26, 2018

Did you know the struct that FileStatLxInformation returns? One problem is that Windows shows a Linux symbolic link as a normal file. And don't remove the C# source codes. I like it.

@DDoSolitary
Copy link
Owner Author

DDoSolitary commented Mar 26, 2018

Did you know the struct that FileStatLxInformation returns?

I haven't investigated it. So I said "Take a look at"... 😄

And don't remove the C# source codes. I like it.

I will delete them, but you can always browse them in the git commit history.

@TomasHubelbauer
Copy link

Do you think that as a convenience feature, a command for creating an icon and attaching it to the taskbar could be added?

Also, would be nice to be able to specify the input image using friendly name as opposed to the app you offer that redirects you to the files, but I expect there is a reason for why that's not already the case, so that's just a nice-to-have for me.

@DDoSolitary
Copy link
Owner Author

It seems to be hard because the dll is not loaded in the LxRunOffline's process.

@DDoSolitary
Copy link
Owner Author

DDoSolitary commented Apr 19, 2018

Take a look at FileStatLxInformation and FileCaseSensitiveInformation.

Just tested both of them. FileCaseSensitiveInformation worked well, but I got some problems on FileStatLxInformation.

  • The returned FILE_STAT_LX_INFORMATION structure has all of the WSL-related fields zero even if NtQueryInformationFile is called on a WSL's file, and I don't how to get it working.

  • As the structure has some read-only fields like FileId and NumberOfLinks, I don't think it can be used by NtSetInformationFile to set the extended attributes. (though not tried yet)

So I decided to stick to NtQueryEaFile and NtSetEaFile.

@DDoSolitary
Copy link
Owner Author

v3 is ready.

@DDoSolitary
Copy link
Owner Author

@TomasHubelbauer I've reopened #27 and will implement this feature later.

@Biswa96
Copy link

Biswa96 commented Jul 6, 2018

Oooo, you're mimicking the behaviour of LxssManager.dll 👌 One thing I've to say. Microsoft WSL programmers are moving towards DRVFS like extended attributes. That is, LXATTRB may be replaced by the FILE_STAT_LX_INFORMATION. wslconfig.exe /upgrade is responsible to do this conversation.

@DDoSolitary
Copy link
Owner Author

DDoSolitary commented Jul 6, 2018

@Biswa96 Really helpful information, could you please give the source?

Just saw the option on the latest insider build, I'll take a look at it.

@DDoSolitary
Copy link
Owner Author

BTW, the duplicate command of v3.0.1 has some known issues. Please use it with care.

@Biswa96
Copy link

Biswa96 commented Jul 10, 2018

A makefile with gcc or g++ will be great.

@DDoSolitary
Copy link
Owner Author

Actually I have got one locally, I'll update it.

@DDoSolitary
Copy link
Owner Author

@Biswa96 Pushed. I'll add build instructions to README later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants