New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gemfile #120
Fix Gemfile #120
Conversation
I always delete the Gemfile.lock coming from the repo. I don't understand why, but my local install does not like it. I don't want to accept this PR blindly but really understand it. Maybe I have time later to review it closely. |
I have to say: I am not at all an expert here. But, these are a lot of dependencies. How can I check that we do indeed need all of those for the current website? |
@StephanJanosch Do you run jekyll via bundle? @knarrff I totally agree. |
usually not. |
I quite understand. For the sake of completeness, By running the bare command, you use the system install and probably run into problems with conflicting versions. |
I do understand the intention that everything should work smoothly when people want to run software. That is very important and often overlooked. Connected to that is to declare dependencies. Although, for me this also includes to only specify as dependency something you actually depend on, and it includes to specify the oldest version of a dependency that your code still works with, instead of only what happens to be current or installed in your system. Therefore my question, is there a good, (semi-)automatic way to get to such a list of dependencies in our case here? I am not too familiar with this setup. What I did is to try to build the pages with the short list of dependencies installed on a fresh system, and it worked. This is no proof that it would have worked with "less", but can I take it as indication that it is likely sufficient? |
@knarrff I see you point and I tried to boil down the dependencies as much as possible. |
Just tried this today. I cannot make this build with my currently system-installed ruby using 'bundle', neither the master-version, nor the one from this pull request. What does work though, is simply 'jekyll build' without using bundle. Now I wonder why I would need 'bundle' at all, and if all the packages and versions given in either of the two Gemfile.lock versions are really necessary - since it apparently works just fine without installing anything extra. I am not familiar with Gemfile.lock and Gemfile files. How are those files generated? In particular, how is the list of dependencies and their versions generated? Because, it seems I can build this project just fine, without some of the packages listed in there, and without updating others to the versions listed there. I have the suspicion that it's just the versions that happened to be installed on the machine the file in generated on, or maybe the then current versions of packages. If it is any of these, it's no good. What we need is a true list of dependencies with their really needed version dependencies. But maybe my suspicion is wrong and I do miss something? |
What command do you execute to build the website?
Running The Gemfile is provided by the user and explicitly defines version constraints of the direct dependencies. By executing
|
The Gemfile currently lacks many dependencies.
This PR uses the gem
github-pages
as a central dependency for the jekyll website and addsrake
for support of theRakefile