BNGP-2885- initial commit for terms and conditions #427
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
usman-j-shaikh
requested review from
paulsimonandrews,
KiranVarma02 and
sfitz42
AjinkyaJawalkar
force-pushed
the
feature/BNGP-2885-credits-t-and-c
branch
from
5b4a9d2
to
e7b0265
Compare
| @@ -1,12 +1,19 @@ | |||
| const routes = { | |||
| ESTIMATOR_CREDITS_INDIVIDUAL_ORG: '/credits-purchase/applying-individual-organisation' | |||
| ESTIMATOR_CREDITS_INDIVIDUAL_ORG: '/credits-purchase/applying-individual-organisation', | |||
| CREDITS_TERM_AND_CONDITIONS: '/credits-purchase/credits-terms-and-conditions', | |||
There was a problem hiding this comment.
Use CREDITS_PURCHASE_TERMS_AND_CONDITIONS
Also the URL should be /credits-purchase/confirm-terms-conditions
| ESTIMATOR_CREDITS_INDIVIDUAL_ORG: '/credits-purchase/applying-individual-organisation' | ||
| ESTIMATOR_CREDITS_INDIVIDUAL_ORG: '/credits-purchase/applying-individual-organisation', | ||
| CREDITS_TERM_AND_CONDITIONS: '/credits-purchase/credits-terms-and-conditions', | ||
| CREDITS_CHECK_YOUR_ANSWERS: '/credits-purchase/credits-check-your-answers' |
There was a problem hiding this comment.
Use CREDITS_PURCHASE_CHECK_YOUR_ANSWERS
| } | ||
|
|
||
| const views = Object.fromEntries( | ||
| Object.entries(routes).map(([k, v]) => [k, v.substring(1)]) | ||
| ) | ||
|
|
||
| const redisKeys = { | ||
| CREDITS_TERMS_AND_CONDITIONS: 'credits-purchase-consent' |
There was a problem hiding this comment.
Use CREDITS_PURCHASE_TERMS_AND_CONDITIONS_CONFIRMED
| <p>The statutory biodiversity credit scheme is run by Natural England on behalf of the Department for Environment, Food and Rural Affairs (Defra) as part of the Environment Act 2021.</p> | ||
|
|
||
| <h2 class="govuk-heading-m">Privacy notice</h2> | ||
| <p class="govuk-body">Our <a href="#">privacy notice </a>sets out how we use the personal data.</p> |
There was a problem hiding this comment.
Use the same link as we use in the footer to the privacy notice: https://www.gov.uk/government/publications/natural-england-privacy-notices/biodiversity-net-gain-privacy-notice
| {% extends 'form-layout.html' %} | ||
|
|
||
| {% set serviceName = "Purchase statutory biodiversity credits" %} | ||
| {% set pageHeading = "Terms and Conditions for the purchase of Statutory Biodiversity Credits" %} |
There was a problem hiding this comment.
Only Terms should be capitalised, the rest should all be lowercase
| <h2 class="govuk-heading-m">Purchase terms</h2> | ||
| <p class="govuk-body">You have no obligation to Natural England to buy the statutory biodiversity credits in this service. The terms and conditions for purchase of statutory biodiversity credits will apply if you proceed.</p> | ||
|
|
||
| <h2 class="govuk-heading-m">Introduction</h2> |
There was a problem hiding this comment.
This heading should be at the top, and the paragraph below is a repeat of what is at the top
| items: [ | ||
| { | ||
| value: "true", | ||
| html: "I confirm I have read the terms and conditions." |
There was a problem hiding this comment.
Should be "I confirm I have read the above, and the full terms and conditions"
| @@ -0,0 +1,58 @@ | |||
| {% extends 'form-layout.html' %} | |||
|
|
|||
| {% set serviceName = "Purchase statutory biodiversity credits" %} | |||
There was a problem hiding this comment.
Should be: "Buy statutory biodiversity credits"
| if (!consent) { | ||
| return h.view(creditsPurchaseConstants.views.CREDITS_TERM_AND_CONDITIONS, { | ||
| err: [{ | ||
| text: 'Check the box to confirm you have read the Ts and Cs', |
There was a problem hiding this comment.
Should be "Check the box to confirm you have read the terms and conditions"
| postOptions.payload.termsAndConditions = undefined | ||
| const res = await submitPostRequest(postOptions, 200) | ||
| expect(res.payload).toContain('There is a problem') | ||
| expect(res.payload).toContain('Check the box to confirm you have read the Ts and Cs') |
There was a problem hiding this comment.
Will need to change as content is wrong in the page
AjinkyaJawalkar
force-pushed
the
feature/BNGP-2885-credits-t-and-c
branch
from
7f5d185
to
cefd280
Compare
| CREDITS_PURCHASE_CHECK_DEFRA_ACCOUNT_DETAILS: '/credits-purchase/check-defra-account-details' | ||
| CREDITS_PURCHASE_CHECK_DEFRA_ACCOUNT_DETAILS: '/credits-purchase/check-defra-account-details', | ||
| CREDITS_PURCHASE_INDIVIDUAL_ORG: '/credits-purchase/applying-individual-organisation', | ||
| CREDITS_PURCHASE_TERMS_AND_CONDITIONS: '/credits-purchase/credits-terms-and-conditions', |
There was a problem hiding this comment.
URL should be: /credits-purchase/confirm-terms-conditions
|
|
Tested by Tajinder |
No description provided.