-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BNGP-4624: Remove old tasklist logic #650
Merged
shaundefra
merged 17 commits into
master
from
feature/BNGP-4624-remove-old-tasklist-logic
Apr 11, 2024
Merged
BNGP-4624: Remove old tasklist logic #650
shaundefra
merged 17 commits into
master
from
feature/BNGP-4624-remove-old-tasklist-logic
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/BNGP-4624 This change removes redundant processRegistrationTask function logic from all registration routes, helper files and associated session data
…d main processRegistrationTask function from helpers.js
Quality Gate passedIssues Measures |
KiranVarma02
previously approved these changes
Feb 28, 2024
KiranVarma02
previously approved these changes
Apr 10, 2024
paulsimonandrews
previously approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…emove-old-tasklist-logic
KiranVarma02
dismissed stale reviews from paulsimonandrews and themself
via
April 11, 2024 09:30
15f1dd2
Quality Gate passedIssues Measures |
KiranVarma02
approved these changes
Apr 11, 2024
tested locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/BNGP-4624
This change removes redundant processRegistrationTask function logic from all registration routes, helper files and associated session data