Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BNGP-4624: Remove old tasklist logic #650

Merged
merged 17 commits into from Apr 11, 2024

Conversation

thousand-leaves
Copy link
Collaborator

https://eaflood.atlassian.net/browse/BNGP-4624

This change removes redundant processRegistrationTask function logic from all registration routes, helper files and associated session data

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thousand-leaves thousand-leaves marked this pull request as ready for review February 28, 2024 09:15
KiranVarma02
KiranVarma02 previously approved these changes Feb 28, 2024
KiranVarma02
KiranVarma02 previously approved these changes Apr 10, 2024
Copy link
Contributor

@paulsimonandrews paulsimonandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KiranVarma02 KiranVarma02 dismissed stale reviews from paulsimonandrews and themself via 15f1dd2 April 11, 2024 09:30
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shaundefra
Copy link
Collaborator

tested locally

@shaundefra shaundefra merged commit b50838e into master Apr 11, 2024
3 checks passed
@shaundefra shaundefra deleted the feature/BNGP-4624-remove-old-tasklist-logic branch April 11, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants