Switch upload to use aws:kms encryption #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-1099 The gem has alwasy encrypted on upload. This means irrespective of whether encryption at rest is enabled on the bucket, any file we upload is encrypted. After a recent review and consultation with AWS, our web-ops team is intending to go through all AWS S3 buckets and set the policy that [all uploads are required to be encrypted using KMS](https://docs.aws.amazon.com/sdk-for-ruby/v3/developer-guide/s3-example-enforce-server-side-encryption.html). We have tested with a bucket where this has been applied and the current upload still works fine. But to ensure there are no issues going forward this change switches the type of encryption we use on upload to KMS. This change should not effect any services still using buckets without the policy. The key thing is whatever we upload is still encrypted. This will just mean when those services are updated they should not encounter any issues with their S3 uploads.
Cruikshanks
requested review from
cintamani and
irisfaraway
and removed request for
cintamani and
irisfaraway
cintamani
approved these changes
Jun 19, 2020
Cruikshanks
added a commit
to DEFRA/flood-risk-back-office
that referenced
this pull request
Jun 19, 2020
https://eaflood.atlassian.net/browse/RUBY-1099 web-ops have asked us to set the encryption for everything uploaded going forward to `AWS:KMS`. This updates the project to a version of [defra-ruby-aws](DEFRA/defra-ruby-aws#20) that uses it.
Cruikshanks
added a commit
to DEFRA/waste-carriers-back-office
that referenced
this pull request
Jun 19, 2020
https://eaflood.atlassian.net/browse/RUBY-1099 web-ops have asked us to set the encryption for everything uploaded going forward to `AWS:KMS`. This updates the project to a version of [defra-ruby-aws](DEFRA/defra-ruby-aws#20) that uses it.
Cruikshanks
added a commit
to DEFRA/flood-risk-back-office
that referenced
this pull request
Jun 21, 2020
https://eaflood.atlassian.net/browse/RUBY-1099 web-ops have asked us to set the encryption for everything uploaded going forward to `AWS:KMS`. This updates the project to a version of [defra-ruby-aws](DEFRA/defra-ruby-aws#20) that uses it.
Cruikshanks
added a commit
to DEFRA/waste-carriers-back-office
that referenced
this pull request
Jun 21, 2020
https://eaflood.atlassian.net/browse/RUBY-1099 web-ops have asked us to set the encryption for everything uploaded going forward to `AWS:KMS`. This updates the project to a version of [defra-ruby-aws](DEFRA/defra-ruby-aws#20) that uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-1099
The gem has alwasy encrypted on upload. This means irrespective of whether encryption at rest is enabled on the bucket, any file we upload is encrypted.
After a recent review and consultation with AWS, our web-ops team is intending to go through all AWS S3 buckets and set the policy that all uploads are required to be encrypted using KMS.
We have tested with a bucket where this has been applied and the current upload still works fine. But to ensure there are no issues going forward this change switches the type of encryption we use on upload to KMS.
This change should not effect any services still using buckets without the policy. The key thing is whatever we upload is still encrypted. This will just mean when those services are updated they should not encounter any issues with their S3 uploads.