Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to upload file in subfolder #23

Merged
merged 4 commits into from
Dec 7, 2020
Merged

Conversation

irisfaraway
Copy link
Member

We need to be able to upload files to S3 in a "subfolder" (or at least with a prefix attached so it looks like this).

This is so we can adapt to the EPR changes and upload files to EPR/export.csv, rather than export.csv.

We need to be able to upload files to S3 in a "subfolder" (or at least with a prefix attached so it looks like this).

This is so we can adapt to the EPR changes and upload files to EPR/export.csv, rather than export.csv.
We shouldn't create the option to add files without also being able to delete them.

Also rename the option to work with more scenarios.
@irisfaraway irisfaraway added the enhancement New feature or request label Dec 7, 2020
@irisfaraway irisfaraway self-assigned this Dec 7, 2020
@irisfaraway
Copy link
Member Author

Tested this out on WEX and it looks to be working! 👍

@irisfaraway irisfaraway merged commit 92781a4 into main Dec 7, 2020
@irisfaraway irisfaraway deleted the feature/filename branch December 7, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant