Skip to content

Commit

Permalink
Remove exclusion for config folder in projects (#21)
Browse files Browse the repository at this point in the history
We spotted in a project recently that new initializers we were adding to the Rails `config/initializers` folder were not being picked up by rubocop.

A quick check of the default rules threw up that we had excluded the folder. The reason given is valid, but on reflection we make so may changes in this folder, and often add many new files that it makes sense to get everything consistent.

The downside is when starting a new project we may be forced to reformat the stuff Rails generates, but overall we think its better to have everything consistent, and that this isn't that onerous a task to do.
  • Loading branch information
Cruikshanks committed Mar 18, 2019
1 parent 6d7e744 commit 9a8a5f4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ AllCops:
- "**/Gemfile"
- "**/Rakefile"
Exclude:
# config contains standard files created when Rails is initialised and
# therefore they should be left as is
- "config/**/*"
# bin contains standard files created when Rails is initialised and
# therefore they should be left as is
- "bin/**/*"
Expand Down
2 changes: 1 addition & 1 deletion lib/defra/style/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module Defra
module Style
VERSION = "0.0.3"
VERSION = "0.1.0"
end
end

0 comments on commit 9a8a5f4

Please sign in to comment.