Add fully styled root page #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than just return some text, this change adds the first proper page to the demo site. This means its adding all the assets needed to properly present the page. It should be noted that the code is essentially copied and pasted from https://github.com/DEFRA/quke-example/tree/master/demo_app. The goal is to replace the code currently in the example, with a simple reference to this gem thereby making the example cleaner and more true to life.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just return some text, this change adds the first proper page to the demo site.
This means its adding all the assets needed to properly present the page. It should be noted that the code is essentially copied and pasted from https://github.com/DEFRA/quke-example/tree/master/demo_app.
The goal is to replace the code currently in the example, with a simple reference to this gem thereby making the example cleaner and more true to life.