GTM activiated by user #1979
Merged
GTM activiated by user #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-4081 Update banner to activate or deactiviate GTM instead of Hapi Gapi
irisfaraway
requested changes
Jun 14, 2024
| @@ -132,7 +132,6 @@ export default (path, view, completion, getData) => ({ | |||
| pageData.analyticsMessageDisplayed = retrieveKeyOrFalse(analytics, ANALYTICS.seenMessage) | |||
| pageData.analyticsSelected = retrieveKeyOrFalse(analytics, ANALYTICS.selected) | |||
| pageData.acceptedTracking = retrieveKeyOrFalse(analytics, ANALYTICS.acceptTracking) | |||
| pageData.gtmContainerId = process.env.GTM_CONTAINER_ID || false | |||
There was a problem hiding this comment.
We still need this value as it's included in the GTM script on the page (see lines 175 and 177 of the njk file)
Comment on lines
17
to
23
| if (optDebug && gtmContainerId) { | ||
| if (canTrack === true) { | ||
| debug(`GTM Container Id: ${gtmContainerId} is being tracked`) | ||
| } else if (pageOmit === true) { | ||
| debug(`GTM Container Id: ${gtmContainerId} is not being tracked for current page`) | ||
| } else { | ||
| debug(`GTM Container Id: ${gtmContainerId} is not being tracked`) |
There was a problem hiding this comment.
The logging here doesn't quite match up with what we had previously – it used to be that we would log if the session was being tracked, and that's what it looks like you are still intending from the tests. However this will just output the same GTM container ID each time, as that is a set thing for the environment.
|
irisfaraway
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-4081
banner activates GTM if approved