Skip to content

Commit

Permalink
Switch airbrake mgmt to defra-ruby-alert
Browse files Browse the repository at this point in the history
Whilst working on an issue for the [Flood Risk Activity Exemptions service](https://github.com/DEFRA/ruby-services-team/tree/master/services/frae) we came across an [issue](DEFRA/flood-risk-engine#312) with Airbrake.

We wanted to add a new Rake task, and we wanted to apply our new pattern of ensuring Airbrake is closed when the task exits to ensure any errors are reported. The problem was due to the age of the Airbrake gem being used this caused an error in FRAE we hadn't seen in WEX and WCR.

So for reasons outlined in [FRAE PR 312](DEFRA/flood-risk-engine#312) we came up with [defra-ruby-alert](https://github.com/DEFRA/defra-ruby-alert). The idea is going forward this will provide a single interface for configuring Airbrake and ensure the pattern of making sure all exceptions are reported before an app closes is applied consistently in all scenarios.

The main changes to enable this have been applied to the [waste-carriers-engine](DEFRA/waste-carriers-engine#657).

These changes finalise the implementation for the back-office, switching out requiring and configuring Airbrake directly, to passing config details through to the WCR engine for it to do it.
  • Loading branch information
Cruikshanks committed Feb 4, 2020
1 parent 6fed5f9 commit 9147f7f
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 9147f7f

Please sign in to comment.