Fix validation on amounts #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: https://eaflood.atlassian.net/browse/RUBY-894 This PR fixes some insconsistency on the way we validate our amounts in the payments and charge adjust forms. This also fixes a bug for which submitting a payment form without an amount results in a 500 error. This bug was dues to the fact that we were not validating the form data before creating a payment on the object when submitting the form . Another issue related to this has to deal with an existing bug on the re-implementation of the Enumerable module from rails, for which the `sum` method called on a `[nil]` collection returns 0 rather than throwing an error. Given this, our test suite was missing to report the error because our test always run on objects with no existing payments.
cintamani
commented
Feb 17, 2020
| @@ -4,8 +4,9 @@ | |||
|
|
|||
| RSpec.describe "ChequePaymentForms", type: :request do | |||
| let(:transient_registration) do | |||
| create(:renewing_registration, :has_finance_details, :does_not_require_conviction_check) | |||
There was a problem hiding this comment.
A standard renewing_registration object is currently created with existing payments. By using the trait, we were overriding the default behaviour by creating empty finance details. In order to reproduce the issue reported in the ticket, given rails/rails#24796, I have removed the specific call to the trait so that we run our code on a collection that also contains other payments.
Cruikshanks
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://eaflood.atlassian.net/browse/RUBY-894
This PR fixes some insconsistency on the way we validate our amounts in the payments and charge adjust forms.
This also fixes a bug for which submitting a payment form without an amount results in a 500 error. This bug was dues
to the fact that we were not validating the form data before creating a payment on the object when submitting the form
.
Another issue related to this has to deal with an existing bug on the re-implementation of the Enumerable module from
rails, for which the
summethod called on a[nil]collection returns 0 rather than throwing an error as per ruby's implementation (rails/rails#24796). Given this,our test suite was missing to report the error because our test always run on objects with no existing payments.