[RUBY-3223] Update defra_ruby_template gem to version 5.4, pinned to …

…major version 5 in Gemfile and Gemfile.lock (#1548)

* [RUBY-3223] Update defra_ruby_template gem to version and use new
govuk-frontend css class

* [RUBY-3223] Update dependencies and improve accessibility in DOB form

- Bump `defra_ruby_template` gem from 5.4.0 to 5.4.1 in Gemfile.lock
- Change DOB hint element from span to div to correct format in shared/_dob.html.erb

Gemfile

@@ -14,7 +14,7 @@ gem "sassc-rails"
 gemspec
 
 # GOV.UK styling
-gem "defra_ruby_template", "~> 3.13.0"
+gem "defra_ruby_template", "~> 5.0"
 
 gem "mongo_session_store"
 

Gemfile.lock

@@ -157,7 +157,7 @@ GEM
       rest-client (~> 2.1)
     defra_ruby_style (0.3.0)
       rubocop (>= 1.0, < 2.0)
-    defra_ruby_template (3.13.0)
+    defra_ruby_template (5.4.1)
     defra_ruby_validators (2.6.0)
       activemodel
       i18n
@@ -472,7 +472,7 @@ DEPENDENCIES
   cancancan (~> 3.5.0)
   database_cleaner-mongoid (~> 2.0.1)
   defra_ruby_style (~> 0.3.0)
-  defra_ruby_template (~> 3.13.0)
+  defra_ruby_template (~> 5.0)
   devise (~> 4.9.2)
   dotenv-rails (~> 2.8.1)
   factory_bot_rails (~> 6.2.0)

app/views/waste_carriers_engine/shared/_dob.html.erb

@@ -7,9 +7,9 @@
   <legend class="govuk-fieldset__legend govuk-fieldset__legend--s">
     <%= t(".dob") %>
   </legend>
-  <span class="govuk-hint" id="person-date-of-birth-hint">
+  <div class="govuk-hint" id="person-date-of-birth-hint">
     <%= t(".dob_hint") %>
-  </span>
+  </div>
 
   <div class="govuk-date-input__item">
     <%= f.govuk_number_field :dob_day,

spec/dummy/app/views/layouts/application.html.erb

@@ -7,7 +7,7 @@
 <% content_for :page_title, title %>
 
 <% content_for :header_content do %>
-  <%= link_to  :global_proposition_header, main_app.root_path, id: "proposition-name", class: "govuk-header__link govuk-header__link--service-name" %>
+  <%= link_to  :global_proposition_header, main_app.root_path, id: "proposition-name", class: "govuk-header__link govuk-header__service-name" %>
 <% end %>
 
 <% content_for :phase_banner do %>