Select contact address from postcode lookup results #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WC-112 Once users have entered a postcode to search with, we should let them choose the address they want from the results and save that as their contact address. This should work the same way as the registered address earlier in the form. We should go with the same inheritance model we've used for the people forms, postcode forms and manual address forms.
This is currently a copy of CompanyAddressForm with the relevant name changes. The next step is refactoring to reduce duplication.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
CompanyAddressForm and ContactAddressForm are very similar, so any shared methods should be inherited from the AddressForm instead.
Cruikshanks
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-112
Once users have entered a postcode to search with, we should let them choose the address they want from the results and save that as their contact address.
This should work the same way as the registered address earlier in the form.
We should go with the same inheritance model we've used for the people forms, postcode forms and manual address forms.