Add code to assign an area to an address through postcode #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private | ||
|
|
||
| def handle_error(error, easting, northing) | ||
| Airbrake.notify(error, easting: easting, northing: northing) if defined? Airbrake |
There was a problem hiding this comment.
Minor: I don't think we need to check whether Airbrake is defined.
PaulDoyle-DEFRA
previously approved these changes
Apr 25, 2023
jjromeo
force-pushed
the
feature/RUBY-2423-wcr-populate-ea-admin-area
branch
from
9876a85
to
9784169
Compare
jjromeo
force-pushed
the
feature/RUBY-2423-wcr-populate-ea-admin-area
branch
from
9777c9b
to
51c0f06
Compare
jjromeo
force-pushed
the
feature/RUBY-2423-wcr-populate-ea-admin-area
branch
from
51c0f06
to
2d38527
Compare
jjromeo
force-pushed
the
feature/RUBY-2423-wcr-populate-ea-admin-area
branch
from
842ed8a
to
62418b4
Compare
brujeo
approved these changes
Apr 26, 2023
| @@ -268,7 +272,7 @@ GEM | |||
| faraday (>= 0.9) | |||
| sawyer (~> 0.8.0, >= 0.5.3) | |||
| orm_adapter (0.5.0) | |||
| os_map_ref (0.5.0) | |||
There was a problem hiding this comment.
This is bit unusual. version 0.1.1 is back from 2016. Any particular reasons for downgrading?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.