Order copy cards #139
Merged
Order copy cards #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WC-248 Before they see the total cost to renew their registration, users are offered the chance to order laminated credit-card-sized copies of their registration. These are currently known as copy cards, but may be renamed to registration cards (or something else) in the future for clarity.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
Started filling in the form with content and a field (defaulting to a value of 0 for now). This content will be fine-tuned in the future.
We have decided to hold off on implementing WorldPay for now and focus on getting as much of the journey done as possible for user testing first. So for now, we will just save the number of cards as a temporary attribute. The field is populated with 0 by default but can be changed to any positive integer (or left blank).
Revise the copy card (or 'registration card') form to include new text from the content designer and an image of an example card.
irisfaraway
added a commit
that referenced
this pull request
Apr 26, 2018
A first pass at setting up the content for the page and saving the user's answer about how they'd like to pay. The copy cards fee depends on a different PR being merged in (#139). For now we've got a temporary holding value.
Cruikshanks
approved these changes
Apr 26, 2018
irisfaraway
added a commit
that referenced
this pull request
Apr 27, 2018
* Add payment summary page https://eaflood.atlassian.net/browse/WC-116 Before they are asked for payment, users should see a summary of the amount they must pay and their options for paying it. This should include the renewal fee, the cost of any copy cards, and the fee for changing the registration type (if applied). This does not cover setting up the order or payment objects in the database as this will be dealt with when WorldPay is implemented. * Set up form values and persist them A first pass at setting up the content for the page and saving the user's answer about how they'd like to pay. The copy cards fee depends on a different PR being merged in (#139). For now we've got a temporary holding value. * Content changes to payment summary and WorldPay substitute Confirm how many cards the user has ordered on the payment summary page. Also add some explanatory copy to the WorldPay substitute page explaining what would happen here once WorldPay is implemented. This is temporary but should make it a bit clearer what is going on during testing. * Move card charge to env vars Move the charge for registration cards to env vars, with the rest of the cards. Also make some minor tweaks now that the registration card page has been merged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-248
Before they see the total cost to renew their registration, users are offered the chance to order laminated credit-card-sized copies of their registration. These are currently known as copy cards, but may be renamed to registration cards (or something else) in the future for clarity.
Note that this PR saves the number of copy cards the user wishes to order, but doesn't start building an Order object yet as this will be saved for implementing payment later.