-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUBY 3081 wcr unblock northern ireland location continue journey #1535
Merged
jjromeo
merged 5 commits into
main
from
RUBY-3081-wcr-unblock-northern-ireland-location-continue-journey
May 8, 2024
Merged
RUBY 3081 wcr unblock northern ireland location continue journey #1535
jjromeo
merged 5 commits into
main
from
RUBY-3081-wcr-unblock-northern-ireland-location-continue-journey
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjromeo
commented
May 8, 2024
•
edited
Loading
edited
- RUBY-3081 Remove MustRegisterInNorthernIrelandForm and replace with RegisterInNorthernIrelandForm
- RUBY-3081 Add transition from NI registration to business type form and update content on NI registration page
… RegisterInNorthernIrelandForm - Delete MustRegisterInNorthernIrelandFormsController and associated views, specs, and locales - Rename state and transitions in workflow from must_register_in_northern_ireland_form to register_in_northern_ireland_form - Update Analytics::UserJourney to remove must_register_in_northern_ireland_form from COMPLETION_PAGES - Modify locales for register_in_northern
… and update content on NI registration page
…ion-continue-journey
timstone
reviewed
May 8, 2024
paragraph_2: You must register with the Environment Agency (EA) if you also carry, broker or deal waste in England. | ||
paragraph_3: Select continue to register with the Environment Agency in England. | ||
next_button: Continue | ||
contact_ea: Contact the EA on 03708 506 506 if you have questions or need help to register. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be using EA abbreviations, this should be the Environment Agency
PaulDoyle-DEFRA
previously approved these changes
May 8, 2024
…e-journey' of https://github.com/DEFRA/waste-carriers-engine into RUBY-3081-wcr-unblock-northern-ireland-location-continue-journey
PaulDoyle-DEFRA
approved these changes
May 8, 2024
jjromeo
deleted the
RUBY-3081-wcr-unblock-northern-ireland-location-continue-journey
branch
May 8, 2024 16:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.