All boolean attributes should be "yes" or "no" #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WC-419 If there are questions where there is a yes or no answer, like smart answers or "Do you have any declared convictions?" we've been saving the answer as a boolean value. However, the old system saves them as a string - "yes" or "no". So we have to update the renewals engine to save and validate these answers as strings instead (at least until we can fix our technical debt).
The boolean fields were other_businesses, is_main_service, only_amf, construction_waste, declared_convictions, temp_os_places_error and temp_tier_check. This commit changes the data type, updates the form values, changes the validation and then fixes the tests. Changing the allowed values also affects the AASM routing, so additional changes were needed here. I would have liked to do these as separate commits, but due to the shared validation, it was difficult to separate.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
Since these fields aren't booleans any more, I renamed the shared validator to reflect what we are actually checking.
Cruikshanks
previously approved these changes
Jul 26, 2018
|
Didn't mean to dismiss that review – gonna go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-419
If there are questions where there is a yes or no answer, like smart answers or "Do you have any declared convictions?" we've been saving the answer as a boolean value.
However, the old system saves them as a string - "yes" or "no".
So we have to update the renewals engine to save and validate these answers as strings instead (at least until we can fix our technical debt).