Send WorldPay emails to contact_email for AD renewals #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WC-489 Users sometimes go through the assisted digital route to renew because they cannot access their account. When a user goes through WorldPay for payment, we send the account email through to WorldPay, which it then uses to send confirmation of the payment. If the user is AD because they can't access the account, this makes the confirmation meaningless. So if a renewal is done via assisted digital, we should be passing the contact email to WorldPay, and not the account email.
The XML should use a different email address when the renewal is AD, so we need a new fixture and a new spec.
Improve the specs to handle this.
We do this by checking if the current user's email matches the renewal account email. If they do, then the user who owns the registration is doing the renewal and it must be digital. If they don't, then another user is doing the renewal on their behalf and it must be assisted digital.
Cruikshanks
approved these changes
Oct 8, 2018
irisfaraway
added a commit
that referenced
this pull request
Dec 7, 2018
https://eaflood.atlassian.net/browse/WC-536 This PR essentially reverts the change made in #278 - when AD users were locked out of their account, we wanted to avoid using an email address they may no longer have access to. However, our registration transfer feature solves that problem, so we can now be consistent about what address we use again.
irisfaraway
added a commit
that referenced
this pull request
Dec 7, 2018
https://eaflood.atlassian.net/browse/WC-536 This PR essentially reverts the change made in #278 - when AD users were locked out of their account, we wanted to avoid using an email address they may no longer have access to. However, our registration transfer feature solves that problem, so we can now be consistent about what address we use again. Also fixed style violations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-489
Users sometimes go through the assisted digital route to renew because they cannot access their account. When a user goes through WorldPay for payment, we send the account email through to WorldPay, which it then uses to send confirmation of the payment. If the user is AD because they can't access the account, this makes the confirmation meaningless.
So if a renewal is done via assisted digital, we should be passing the contact email to WorldPay, and not the account email.