Refactor transient registration unit tests #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started by following http://www.betterspecs.org/#describe and ensuring where we are describing an instance method we start the description with a #. However then to make this task a little easier, decided to reorder the tests slightly so that shared examples come first, then anything related to attributes, followed by the instance methods. So did that, and the # in descriptions, but then spotted we were testing a method that actually came from a concern and was not directly on the `TransientRegistration` class. This should really be in a shared example to make it clearer its not directly tied to the transient registration class, so also made that tweak.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
irisfaraway
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started by following http://www.betterspecs.org/#describe and ensuring where we are describing an instance method we start the description with a #.
However then to make this task a little easier, decided to reorder the tests slightly so that shared examples come first, then anything related to attributes, followed by the instance methods.
So did that, and the # in descriptions, but then spotted we were testing a method that actually came from a concern and was not directly on the
TransientRegistrationclass.This should really be in a shared example to make it clearer its not directly tied to the transient registration class, so also made that tweak.