Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rubocop to CI #356

Merged
merged 3 commits into from
Jan 4, 2019
Merged

Add Rubocop to CI #356

merged 3 commits into from
Jan 4, 2019

Conversation

irisfaraway
Copy link
Member

Make Travis run Rubocop before running the RSpec suite so we catch any style violations.

This resolves https://github.com/DEFRA/waste-carriers-renewals/issues/176

@irisfaraway
Add Rubocop to CI
69e8e29 
Make Travis run Rubocop before running the RSpec suite so we catch any style violations.

This resolves https://github.com/DEFRA/waste-carriers-renewals/issues/176
@irisfaraway irisfaraway added the housekeeping Changes such as refactoring label Jan 4, 2019
@irisfaraway irisfaraway self-assigned this Jan 4, 2019
@irisfaraway
Copy link
Member Author

Rubocop now runs, but fails the build – which is expected as #355 hasn't been merged yet.

Once #355 is merged in, all remaining style violations should be resolved, and the build should pass.

@irisfaraway
Copy link
Member Author

irisfaraway commented Jan 4, 2019 •
edited

image
[heavenly choir sounds]

Cruikshanks
Cruikshanks approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clapping

@irisfaraway irisfaraway merged commit 8cccfb7 into master Jan 4, 2019
@irisfaraway irisfaraway deleted the fix/rubocop-ci branch January 4, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cruikshanks Cruikshanks Cruikshanks approved these changes

Assignees

@irisfaraway irisfaraway

Labels
housekeeping Changes such as refactoring
Projects
None yet
Milestone
No milestone
2 participants
@irisfaraway @Cruikshanks