Improve database seeding #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WC-167 We need some seed data for the database for the dev environment and for running acceptance tests against. This change switches from loading all seeds in a single script to storing seeds as multiple JSON files and then loading them. This approach should make it easier to add and modify seeds.
Seeds with regIdentifiers are loaded first. Then ones without regIdentifiers are loaded and assigned new regIdentifiers to 'fill in the gaps'. This change includes a refactor of the CanGenerateRegIdentifier concern to continue incrementing the counter if it would clash with a regIdentifier which was added out of sequence.
|
@Cruikshanks This is ready for a review. You'll probably want to play around with the seed data, especially adding different Hakiri has flagged up an issue – I've looked into this and don't think it is a risk as the value it's concerned about (the regid counter) should only be modified by the application and not by any data from users, etc. What do you think? |
|
We've also got some docs (🎉 ) here: https://github.com/DEFRA/waste-carriers-renewals/wiki/Database-seeding |
Cruikshanks
approved these changes
Jan 15, 2018
irisfaraway
force-pushed
the
feature/db-seeding
branch
from
abaa75a
to
2dbfc86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-167
We need some seed data for the database for the dev environment and for running acceptance tests against. This change switches from loading all seeds in a single script to storing seeds as multiple JSON files and then loading them. This approach should make it easier to add and modify seeds.