Fix error routes to contain a constraint for the /error path #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of: https://eaflood.atlassian.net/browse/RUBY-261 The dummy app inside the WEX engine correctly handles 404 and 500 errors but the applications that inherit from the engine always render a general template for every error. This is because the wrong path is sent together as an ":id" and hence the information about the error template to use is lost in time and space. Changing the URL constraint fixed this issue. Hence the URL constraint is also going to change here for consistency and to prevent regression.
Cruikshanks
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: https://eaflood.atlassian.net/browse/RUBY-261
The dummy app inside the WEX engine correctly handles 404 and 500 errors but the applications
that inherit from the engine always render a general template for every error.
This is because the wrong path is sent together as an ":id" and hence the information about the error template to use is lost in time and space.
Changing the URL constraint fixed this issue.
Hence the URL constraint is also going to change here for consistency and to prevent regression.