Forms Refactoring -Add ability to reference single document in collection #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction From: https://eaflood.atlassian.net/browse/RUBY-693 In Wex, using Active Record, we were able to simplify a lot our logic around addresses forms by redefining the association to the address as `has_one` associations. Currently, there is no way to do the same with MongId 5.2, hence this adds some metaprogramming code that will allow a mode l to define a single object that is persisted inside a location and to override it.
cintamani
force-pushed
the
reference-one-object-in-collection
branch
from
78e000e
to
f690846
Compare
cintamani
commented
Oct 14, 2019
app/models/concerns/waste_carriers_engine/can_have_registration_attributes.rb
Outdated
Show resolved
Hide resolved
Cruikshanks
requested changes
Oct 14, 2019
app/models/concerns/waste_carriers_engine/can_have_registration_attributes.rb
Show resolved
Hide resolved
| registration.registration_type != registration_type | ||
| end | ||
|
|
||
| def registration |
app/models/concerns/waste_carriers_engine/can_reference_single_document_in_collection.rb
Show resolved
Hide resolved
app/models/concerns/waste_carriers_engine/can_have_registration_attributes.rb
Outdated
Show resolved
Hide resolved
Cruikshanks
requested changes
Oct 15, 2019
Comment on lines
3
to
6
| # This module's aim is to implement a way to reference documetns in collection but singularly | ||
| # so that they can be treated as `has_one` associations. Currently on the WEX project we achieve the same | ||
| # functionality thanks to ActiveRecord Relation ability of specify custom associations using default scopes. | ||
| # But with the version of MongoId we use there is no ability of doing so. |
There was a problem hiding this comment.
Suggested change
| # This module's aim is to implement a way to reference documetns in collection but singularly | |
| # so that they can be treated as `has_one` associations. Currently on the WEX project we achieve the same | |
| # functionality thanks to ActiveRecord Relation ability of specify custom associations using default scopes. | |
| # But with the version of MongoId we use there is no ability of doing so. | |
| # This module's aim is to implement a way to reference a single document in a | |
| # collection so that they can then be treated as `has_one` associations. | |
| # In projects using ActiveRecord like WEX we achieve the same functionality | |
| # thanks to ActiveRecord's Relation ability to specify custom associations using | |
| # default scopes. But because here we are using an old version of MongoDB, we | |
| # are also stuck with a version of Mongoid which does not have this ability. |
There was a problem hiding this comment.
Turns out multiline comments don't apply to multiline suggestions
There was a problem hiding this comment.
yep it does not! Shame! :D
Cruikshanks
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://eaflood.atlassian.net/browse/RUBY-693
In Wex, using Active Record, we were able to simplify a lot our logic around addresses forms by redefining the association to the address as
has_oneassociations.Currently, there is no way to do the same with MongId 5.2, hence this adds some metaprogramming code that will allow a mode l to define a single object that is persisted inside a location and to override it.