Move setting up of ASSISTED_DIGITAL flag in AASM machine #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cintamani
added
bug
cintamani
commented
Oct 23, 2019
app/services/waste_carriers_engine/renewal_completion_service.rb
Outdated
Show resolved
Hide resolved
Solve: https://eaflood.atlassian.net/browse/RUBY-718 We used the `RenewalCompletionService` to setup the metaData route of the transient_registration to the correct application-level configuration of `ASSISTED_DIGITAL` vs `DIGITAL`. This was causing some registration to be incorrectly flagged as `ASSISTED_DIGITAL`, because the same service is run in the back-office application when a conviction check or payment check have been completed. In order to make sure that we only flag the registration at the end of the forms workflow, we have moved the setting from the Service to the workflow AASM state machine.
cintamani
force-pushed
the
718-assisted-digital-flagging
branch
from
15c843d
to
317fa23
Compare
cintamani
changed the title
cintamani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve: https://eaflood.atlassian.net/browse/RUBY-718
We used the
RenewalCompletionServiceto setup the metaData route of the transient_registration to the correct application-level configuration ofASSISTED_DIGITALvsDIGITAL.This was causing some registration to be incorrectly flagged as
ASSISTED_DIGITAL, because the same service is run in the back-office application when a conviction check or payment check have been completed.In order to make sure that we only flag the registration at the end of the forms workflow, we have moved the setting from the Service to the workflow AASM state machine.