Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with blank company_nos correctly. #56

Merged
merged 2 commits into from
Jan 29, 2018
Merged

Conversation

irisfaraway
Copy link
Member

This bug was flagged up in QA. Instead of just asking the user to enter a number, the app was attempting to turn the blank input into a valid number by adding 0s. This resulted in a company_no of 00000000.

@irisfaraway irisfaraway self-assigned this Jan 29, 2018
@irisfaraway irisfaraway merged commit ca26719 into master Jan 29, 2018
@irisfaraway irisfaraway deleted the fix/company_no_bugs branch January 29, 2018 12:17
@irisfaraway irisfaraway added the bug Something isn't working label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant